-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of test fixtures #1
Comments
Ultimately, the 'fixtures' directory will host files containing long CSL data, such as the locales or styles that are used by many test cases. The tests themselves will go under 'features', however they will use a different format. Perhaps we could put the current tests under 'resource/std' or 'data/std'? My apologies that this has not progressed further! Just this week I convinced a fellow developer to assist me, so I hope to bring this up to speed soon. |
Ah, of course that's right. "resource/std" sounds good. Will move things after hearing back from Bruce and Andrea as well. |
Sorry for the delay of my answer but I was away in the last couple of weeks. With reference to the migration I do not have any objections. |
Having just gotten a question on the bitbucket repo, I'm confused on where we're at with this. Also reminds me, this needs a meangingful readme to clarify. |
As a quick and dirty short-term fix for a README, I've copied the (outdated) source of the test suite manual up to that position. Feel free to edit or redraft the text if you feel it is opaque or addresses the wrong audience. I'll try to check and update the specifics when I'm able to get to it. As far as I know, developers are still using the test fixtures in their current home-brew format. I add fixtures as required to address bug reports against citeproc-js (which are now pretty infrequent). Tests that exercise functionality specific to citeproc-js are (or at least should be) housed separately, in the citeproc-js sources. I don't know where things stand with Sylvester's project to recast the tests in Cucumber format, or with proposals to classify or possibly curate the fixtures, but I'll be happy to rearrange the files (or turn over the keys to someone else to do so) if that's needed. |
Also, if you would prefer to house the fixtures in the CSL area on GitHub, feel free to move them across. Just leave a pointer here so that developers (including myself) can make local adjustments. |
There just was another call to move Frank's test fixtures from Bitbucket to GitHub (https://bitbucket.org/bdarcus/citeproc-test/issues/5/convert-tests-to-cucumber-or-similar). It's probably easiest to use GitHub's importer (https://help.github.com/articles/importing-your-project-to-github/), which would create a new repository. Maybe we can call the new repo "tests" or "processor-tests", and retire the current "test-suite" repo? |
👍 |
Absolutely no objection here. On Thu, Feb 18, 2016 at 6:12 PM, John Vandenberg [email protected]
|
If we want to keep using the "test-suite" repo name, I could:
We can then copy over any files from "test-suite-old" or just delete this repo. Sounds good? |
+1👍 |
To bring everything under one roof, I should migrate the test fixtures at some point. The first step will be to confirm the move with developers (practically speaking, I think that means Bruce, Sebastian and Andrea). Once everyone has given the nod, I would move the existing tests from BitBucket to a "std" directory under "fixtures".
Feel free to signal assent as a comment to this issue. I'll also post a note to xbiblio-devel.
The text was updated successfully, but these errors were encountered: