#7782 - catch when Postgres planning removes all Citus tables #7907
+169
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7907 +/- ##
================================================
- Coverage 89.48% 89.46% -0.03%
================================================
Files 276 276
Lines 60063 59903 -160
Branches 7524 7514 -10
================================================
- Hits 53747 53590 -157
- Misses 4166 4168 +2
+ Partials 2150 2145 -5 |
colm-mchugh
force-pushed
the
colm/issue_7782
branch
from
278d9f3 to
1c472be
Compare
This was
linked to
issues
Feb 20, 2025
colm-mchugh
force-pushed
the
colm/issue_7782
branch
3 times, most recently
from
7cf5873 to
63725bf
Compare
|
What an interesting failure! Thanks for this PR. We modify the |
DESCRIPTION: fix a planning error caused by a redundant WHERE clause (of the form WHERE true OR <expression>) Fix a Citus planning glitch, where the WHERE clause of the query is of the form: ` WHERE true OR <expression with 1 or more citus tables> ` and this is the only place in the query referencing a citus table. Postgres' standard planner transforms the WHERE clause to: ` WHERE true ` So the query now has no citus tables, confusing the Citus planner as described in issues #7782 and #7783. The fix is to check, after Postgres standard planner, if the Query has been transformed as shown, and re-run the check of whether or not the query needs distributed planning.
colm-mchugh
force-pushed
the
colm/issue_7782
branch
from
63725bf to
030d05a
Compare
Sure; this seems to be the best (only?) way to deal with this planning quirk, but lmk what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: fix a planning error caused by a redundant WHERE clause
Fix a Citus planning glitch that occurs in a DML query when the WHERE clause of the query is of the form:
WHERE true OR <expression with 1 or more citus tables>and this is the only place in the query referencing a citus table. Postgres' standard planner transforms the WHERE clause to:
WHERE trueSo the query now has no citus tables, confusing the Citus planner as described in issues #7782 and #7783. The fix is to check, after Postgres standard planner, if the Query has been transformed as shown, and re-run the check of whether or not the query needs distributed planning.