Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 13.0 Improve handling of unsupported collation-encoding combinations #7834

Closed
m3hm3t opened this issue Jan 6, 2025 · 5 comments
Closed
Assignees

Comments

@m3hm3t
Copy link
Contributor

m3hm3t commented Jan 6, 2025

Queries using incompatible collations and encodings, such as da_DK.utf8 with SQL_ASCII, result in errors like:

ERROR: collation "da_DK.utf8" for encoding "SQL_ASCII" does not exist
ERROR: collation "pg_c_utf8" for encoding "SQL_ASCII" does not exist

Steps to Reproduce:
Execute a query specifying an unsupported collation:
CREATE TABLE test_table (id INT COLLATE "da_DK.utf8");

Expected Behavior:
Distributed query validation may catch unsupported configurations and provide actionable error messages.

Suggested Solution:

  • Validate collation-encoding compatibility during table creation.
  • Enhance error messages to provide actionable guidance.

Severity:
Not a blocker:

SQL_ASCII is rarely used in modern databases. It is considered outdated and is generally not recommended for new applications.

@m3hm3t m3hm3t self-assigned this Jan 6, 2025
@m3hm3t
Copy link
Contributor Author

m3hm3t commented Jan 6, 2025

This problem with da_DK.utf8 also occurs in the release-12.1 tests.

@m3hm3t
Copy link
Contributor Author

m3hm3t commented Jan 6, 2025

@onurctirtir
Copy link
Member

Same here, as long as we get the same error message as what we would get for Postgres tables, I'd not say that this is a Citus issue.

@m3hm3t
Copy link
Contributor Author

m3hm3t commented Jan 8, 2025

Same here, as long as we get the same error message as what we would get for Postgres tables, I'd not say that this is a Citus issue.

My conclusion as well that this is not a Citus-specific issue but a PostgreSQL limitation.

@onurctirtir
Copy link
Member

I think we can close the issue then.

@m3hm3t m3hm3t closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants