Add hook package for handling Kubernetes node draining event #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
changed the title
hlts2
changed the title
hlts2
changed the title
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
changed the title
hlts2
requested review from
rytswd,
chadmcrowell,
RealHarshThakur and
Praveen005
Signed-off-by: hlts2 <[email protected]>
hlts2
commented
Jan 15, 2025
hlts2
commented
Jan 15, 2025
RealHarshThakur
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR includes a lifecycle hook (PreStop) method to handle node draining and termination events.
WHY
The primary goal of this PR is to implement a lifecycle hook (Hook interface) for handling Kubernetes node draining events, particularly in the PreStop lifecycle stage. The need arises from the requirement to ensure that VolumeAttachments associated with a node are properly cleaned up before the node is fully drained or shut down.
FYI
This PR implements a package that primarily handles hook processing. Once this PR is merged, the next step will be to update
main.goand themanifestto incorporate this functionality by adding the PreStop lifecycle event handling.This package is independent, so it does not affect existing functionality.
The usage is implemented in the following PR.