Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

Library items which have linkage missing from SnapSVGAnimator #118

Open
herrKlein opened this issue Dec 13, 2017 · 0 comments
Open

Library items which have linkage missing from SnapSVGAnimator #118

herrKlein opened this issue Dec 13, 2017 · 0 comments

Comments

@herrKlein
Copy link

I had some weird issues with library items which didn't show up in the linkage.

The corresponding library items were in the JSON file, but were not processed by SnapSVGAnimator. It seemed that this piece of code is the culprit

for (i = data.DOMDocument.Timeline.length - 1; i > -1; i -= 1) {
  if (typeof(data.DOMDocument.Timeline[i].linkageName) !== 'undefined') {
    instance.linkage[data.DOMDocument.Timeline[i].linkageName] = data.DOMDocument.Timeline[i];
  } else {
    maintimelineIndex = i;
    // break;
  }
}

When a library item without linkage name is detected, the code enters the else part where there is a break. From this point on, no further library items are processed. When I uncomment the break it works for now.

Can someone verify this bug and make a correct fix. ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant