Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce test command for built package version #184

Closed
Dumluregn opened this issue Mar 18, 2021 · 2 comments · Fixed by #199
Closed

Introduce test command for built package version #184

Dumluregn opened this issue Mar 18, 2021 · 2 comments · Fixed by #199
Assignees
@MMMalik
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
2.0.0

Comments

@Dumluregn
Copy link
Contributor

Dumluregn commented Mar 18, 2021 •
edited
Loading

Are you reporting a feature request or a bug?

New feature

Details

Follow-up of #166 (comment) and #166 (review).

We should introduce npm script launching the tests for the built package version (currently development version is tested). It should then be run as a separate job on CI with React tester. So in the end of the day we want to have two jobs on CI:

  • latest React version + dev package version for quick feedback;
  • all React versions (latest minors) + build package version for full feedback.

And two npm test scripts:

  • npm run test running tests for built package version;
  • npm run test:dev running tests for development package version.

And React tester should use the first one (npm run test) by default.
@Dumluregn Dumluregn added status:confirmed An issue confirmed by the development team. type:feature A feature request. labels Mar 18, 2021
@Dumluregn Dumluregn mentioned this issue Mar 18, 2021
Merged
@Dumluregn Dumluregn added type:task Any other issue (refactoring, typo fix, etc). type:feature A feature request. and removed type:feature A feature request. type:task Any other issue (refactoring, typo fix, etc). labels Mar 19, 2021
@f1ames f1ames added the size:S label Mar 29, 2021
@MMMalik MMMalik self-assigned this Apr 2, 2021
@f1ames
Copy link
Contributor

f1ames commented Apr 6, 2021

Let's pause this task until we decide how to handle #159 as it will give us more insight how to proceed with this one more effectively.

@f1ames f1ames added the status:blocked An issue which development is blocked by another issue (internal or external one). label Apr 6, 2021
@f1ames f1ames removed the status:blocked An issue which development is blocked by another issue (internal or external one). label Apr 23, 2021
@MMMalik MMMalik mentioned this issue Apr 23, 2021
Merged
@MMMalik MMMalik linked a pull request Apr 23, 2021 that will close this issue
Prepare ground for v2 #199
Merged
@CKEditorBot CKEditorBot added this to the 2.0.0 milestone Jun 4, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MMMalik MMMalik

Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Prepare ground for v2 ckeditor/ckeditor4-react
4 participants
@f1ames @Dumluregn @MMMalik @CKEditorBot