Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11ychecker.check() method always show UI #227

Open
mlewand opened this issue Sep 21, 2016 · 1 comment
Open

A11ychecker.check() method always show UI #227

mlewand opened this issue Sep 21, 2016 · 1 comment
Labels
bug internals

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 21, 2016 •
edited
Loading

Currently Controller.check() will allways show UI, despite options.ui = false.

I can see a source of the problem in editableDecorator.markIssues call in CheckingMode. This mode is enabled (and should be) when engine is checking the content.

The solution here would be passing options also to the mode instance, so it can check whether or not UI should be shown.
@mlewand mlewand changed the title A11ychecker.check() method always show ui A11ychecker.check() method always show UI Sep 21, 2016
@mlewand
Copy link
Contributor Author

mlewand commented Sep 21, 2016

I've pushed t/227 branch with a manual test in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlewand