Merge pull request #23 from clappr/fix-cc-options

Closed Captions - Simplify binds on the core instance
clappr · Nov 13, 2020 · bd2902f · bd2902f
2 parents dde8186 + 4e95fe7
commit bd2902f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/.hound.yml b/.hound.yml
@@ -1,3 +1,3 @@
-java_script:
+eslint:
   enabled: true
-  config_file: .eslintrc.js
+  config_file: .eslintrc.json
diff --git a/src/plugins/closed_captions/closed_captions.js b/src/plugins/closed_captions/closed_captions.js
@@ -35,18 +35,11 @@ export default class ClosedCaptions extends UICorePlugin {
   }
 
   bindEvents() {
-    this.bindCoreEvents()
-    this.bindContainerEvents()
-  }
+    this.listenTo(this.core, Events.CORE_ACTIVE_CONTAINER_CHANGED, this.containerChanged)
+    this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_RENDERED, this.render)
+    this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_HIDE, this.hideContextMenu)
 
-  bindCoreEvents() {
-    if (this.core.mediaControl.settings) {
-      this.listenTo(this.core, Events.CORE_ACTIVE_CONTAINER_CHANGED, this.containerChanged)
-      this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_RENDERED, this.render)
-      this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_HIDE, this.hideContextMenu)
-    } else {
-      setTimeout(() => this.bindCoreEvents(), 100)
-    }
+    this.bindContainerEvents()
   }
 
   bindContainerEvents() {