v5.0.0-rc.9 - enhancement: Excel cell merge support, closes #69

clarketm · Jun 24, 2017 · a0eaaaa · a0eaaaa
1 parent f37668b
commit a0eaaaa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dist/js/tableexport.js b/dist/js/tableexport.js
@@ -127,6 +127,7 @@
                         if (!_isValidFormat(key)) {
                             return _handleError('"' + key + '" is not a valid format. \nFormats: ' + _FORMAT_LIST.join(', '))
                         } else if (!_hasDependencies(key)) {
+                            // TODO: provide a fallback option to XLS?
                             return _handleError('"' + key + '" requires "js-xlsx".');
                         } else if (!formatMap[key]) {
                             context.setExportData(self.exporters.build.call(self, context, key));
@@ -569,6 +570,7 @@
                     var dataURI = 'data:' + mime + ';' + this.charset + ',' + data;
                     this.downloadDataURI(dataURI, name, extension);
                 } else {
+                    // TODO: error and fallback when `saveAs` not available
                     saveAs(new Blob([data],
                         {type: mime + ';' + this.charset}),
                         name + extension, true);

diff --git a/src/stable/js/tableexport.js b/src/stable/js/tableexport.js
@@ -127,6 +127,7 @@
                         if (!_isValidFormat(key)) {
                             return _handleError('"' + key + '" is not a valid format. \nFormats: ' + _FORMAT_LIST.join(', '))
                         } else if (!_hasDependencies(key)) {
+                            // TODO: provide a fallback option to XLS?
                             return _handleError('"' + key + '" requires "js-xlsx".');
                         } else if (!formatMap[key]) {
                             context.setExportData(self.exporters.build.call(self, context, key));
@@ -569,6 +570,7 @@
                     var dataURI = 'data:' + mime + ';' + this.charset + ',' + data;
                     this.downloadDataURI(dataURI, name, extension);
                 } else {
+                    // TODO: error and fallback when `saveAs` not available
                     saveAs(new Blob([data],
                         {type: mime + ';' + this.charset}),
                         name + extension, true);