Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the release of clash-cores #2757

Open
2 of 9 tasks
martijnbastiaan opened this issue Jul 18, 2024 · 4 comments
Open
2 of 9 tasks

On the release of clash-cores #2757

martijnbastiaan opened this issue Jul 18, 2024 · 4 comments

Comments

@martijnbastiaan
Copy link
Member

martijnbastiaan commented Jul 18, 2024

Tasks:

@clash-lang clash-lang deleted a comment from martijnbastiaan Jul 19, 2024
@clash-lang clash-lang deleted a comment from martijnbastiaan Jul 19, 2024
@DigitalBrains1
Copy link
Member

I think it would be good if we could merge the fourmolu formatting PR on clash-compiler before we split the repo's, so there is no need for another .git-blame-ignore-revs file in the new repo. But it's not a really big issue, just a nice-to-have.

@DigitalBrains1
Copy link
Member

Do we want to split off the full history of everything happening in clash-compiler/clash-cores into the new repository, using git subtree?

Or do we want a new initial commit on the new repo with all the code as it currently is, and direct people to clash-compiler for the history before that?

@t-wallet and I both prefer the first.

@jvnknvlgl
Copy link
Collaborator

I have added a clash-cores label to mark everything that needs to be moved to the new repository when the time is there.

@leonschoorl
Copy link
Member

There are still many references to clash-cores in the CI infra:

cabal v2-run clash-cores:doctests
cabal v2-run clash-cores:unittests -- --hide-successes

cores:doctests:
extends: .test-nocache
script:
- bin/clash-cores:doctests -j$THREADS

cores:unittests:
extends: .test-nocache
script:
- bin/clash-cores:unittests --hide-successes

# Vivado is quite slow, so we only run a subset of the tests on development branches
# with it. The full testsuite gets run with Vivado every night on 'master'.
suite:cores:
extends: .test-cache-local
script:
- source /opt/tools/Xilinx/Vivado/2022.1/settings64.sh
- bin/clash-testsuite:clash-testsuite -j$THREADS -p Cores --hide-successes --no-modelsim --no-ghdl --no-iverilog --no-verilator --no-symbiyosys
tags:
- local
- vivado-2022.1-standard

That last one is now completely pointless after #2793 got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants