Render CompDecl in VHDL decl function

[christiaanb]

Instead of rendering them in inst_. I noticed that while creating a primitive that when I used a combination of compInBlock and instDecl Empty that the entire block declaration and its declarative part were elided; leaving only the portmap.

So before this change, the following primitive declaration:

  = do
    plusFloatInstName <- Id.makeBasic "plusFloat_inst"

    let
      compInps =
        [ ("clk", N.Bit)
        , ("arg1", DSL.ety a)
        , ("arg2", DSL.ety b) ]
      compOuts =
        [ ("dout", DSL.ety result) ]

      plusFloatName = "plusFloat"

    DSL.declaration "plusFloat_inst_block" $ do
      DSL.compInBlock "plusFloat" compInps compOuts

      let
        inps =
          [ ("clk", clk )
          , ("arg1", a)
          , ("arg2", b)
          ]

        outs =
          [ ("dout", result)
          ]

      DSL.instDecl Empty (Id.unsafeMake plusFloatName) plusFloatInstName
        [] inps outs

would get translated to:

    plusFloat_inst : plusFloat
      port map
        ( clk  => clk
        , arg1 => y
        , arg2 => z
        , dout => \c$app_arg\ );

instead of the expected:

  plusFloat_inst_block : block
    component plusFloat port
      ( clk : in std_logic
      ; arg1 : in std_logic_vector(31 downto 0)
      ; arg2 : in std_logic_vector(31 downto 0)
      ; dout : out std_logic_vector(31 downto 0) );
    end component;
  begin
    plusFloat_inst : plusFloat
      port map
        ( clk  => clk
        , arg1 => y
        , arg2 => z
        , dout => \c$app_arg\ );


  end block;

Still TODO:

• Check copyright notices are up to date in edited files

[christiaanb]

@DigitalBrains1 Could you review the change? I'm mostly asking you because you also reviewed #2255 which introduced component declarations.

[DigitalBrains1]

I am wildly unfamiliar with this part of our codebase :-D. I can't say anything pertinent about this PR.

(I notice in the PR you refer to I say "I've got something to say" and then Martijn requests my review but I never said anything else X-D. I suppose my point was already made by another reviewer.)