Add SGMII support to clash-cores

[jvnknvlgl]

Add support for connecting to Ethernet PHYs using SGMII to clash-cores.

References: SGMII and IEEE 802.3.

Still TODO:

• Write a changelog entry (see changelog/README.md)
• Check copyright notices are up to date in edited files

[lmbollen]

pls apply everywhere

[rowanG077]

I didn't look into the implementation just at the changed files. But is it possible to separate the 8b/10b encoding from SGMII? There are a ton of more uses for it.

[jvnknvlgl]

I didn't look into the implementation just at the changed files. But is it possible to separate the 8b/10b encoding from SGMII? There are a ton of more uses for it.

Should very much be possible, yes, and I think it would make sense to handle this as a separate PR as well to break things up a bit. Do note that this is not a very 'advanced' 8b/10b implementation as it's basically just two large lookup tables.

[jvnknvlgl]

I have moved the 8b/10b encoder and decoder to a different branch, see #2738.

[christiaanb]

Could you use 8b10b instead of EbTb; this makes it easier for people to find/google the 8b10b encoders and decoders.

[christiaanb]

LGTM module the one question/comment

[jvnknvlgl]

Great, thank you very much!

[jvnknvlgl]

Is there anything specific that still needs to happen for this to be merged? I know that clash-cores now lives in its own repository, but I don't really know how to move a PR to a different repository.

[DigitalBrains1]

I will move it soon. With CI passing and Christiaan giving the go-ahead, I don't think there's anything else preventing this from being merged.

Could you write what you'd like the commit message to be? That way I don't have to come up with one.

[jvnknvlgl]

Thanks!

The title of this PR (Add SGMII support to clash-cores) sounds very reasonable to me.

[DigitalBrains1]

I'd like to suggest using the PR cover letter as detailed message (some slight reformatting):

Add SGMII support to `clash-cores`

Add support for connecting to Ethernet PHYs using SGMII to `clash-cores`.

References:
 - SGMII: https://archive.org/download/sgmii/SGMII.pdf
 - IEEE 802.3: https://standards.ieee.org/ieee/802.3/10422/

[jvnknvlgl]

Ah, that looks good to me!

[DigitalBrains1]

Heh. Maybe change it a bit more. The "add X to clash-cores" is just a bit weird when clash-cores is the name of the repo. It's like a PR here titled "add X to clash-compiler". It's kinda implied.

Add SGMII support

Add support for connecting to Ethernet PHYs using SGMII

References:
 - SGMII: https://archive.org/download/sgmii/SGMII.pdf
 - IEEE 802.3: https://standards.ieee.org/ieee/802.3/10422/

That okay?

[jvnknvlgl]

LGTM!

[jvnknvlgl]

Merged into clash-cores in clash-lang/clash-cores#17