Skip to content
This repository has been archived by the owner on Nov 30, 2018. It is now read-only.

Shellcheck #27

Open
Cody-Learner opened this issue Feb 24, 2018 · 2 comments
Open

Shellcheck #27

Cody-Learner opened this issue Feb 24, 2018 · 2 comments
Assignees

Comments

@Cody-Learner
Copy link

Cody-Learner commented Feb 24, 2018

Not sure how it works, but did you transpose some digits somewhere other than the comments in the aursec-parse-srcinfo script? Does shellcheck read the commented line in the script?

ie:
In bin/aursec-parse-srcinfo line 26:
if [[ "$val" =~ .*::(.git(@|+http).|.svn(+http|://).|.bzr+http.|.hg+http.) ]]; then
^-- SC1009: The mentioned parser error was in this regex grouping.
^-- SC1073: Couldn't parse this regex grouping.
^-- SC1072: Unexpected . Fix any mentioned problems and try again.
-vs-

# shellcheck disable=SC1702,SC1703,SC1009

I tried rebuilding after today's update on the AUR and still can't.

@clawoflight clawoflight self-assigned this Feb 26, 2018
@clawoflight
Copy link
Owner

Yeah, I don't understand why it doesn't work with the Arch package...
As you can see, it worked in CI, where shellcheck is built from git: https://circleci.com/gh/clawoflight/aursec/307

Also, welcome to github! :)

@clawoflight
Copy link
Owner

These are multiple upstream bugs:

The disabling doesn't work per shellcheck/#1118, and the wiki post on SC1702 may be applicable as well.

Wait and see for the next upstream release, I guess...
and

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants