Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up FC and FFLAGS in Makefiles #49

Closed
rjleveque opened this issue Jul 26, 2013 · 1 comment · Fixed by #54
Closed

clean up FC and FFLAGS in Makefiles #49

rjleveque opened this issue Jul 26, 2013 · 1 comment · Fixed by #54
Milestone

Comments

@rjleveque
Copy link
Member

Application/example Makefiles should say:

FFLAGS ?=

and not mention FC.

Users should be encouraged to set environment variable FFLAG for the flags they generally want. (Add documentation page.)

Makefile.common will check if FC is set to f77 (which it is by default on some systems) and if so, reset to gfortran (since f77 won't work). Users who want to use ifort or another compiler can set environment variable FC.

Default Makefiles will not have -fopenmp

Remove all the commented out lines in various Makefiles, add documentation to list standard combinations of FC and FFLAGS that users might want to use.

This will clean up Makefiles and also avoid developers checking in modified Makefiles with flags that don't work for others.

@mandli
Copy link
Member

mandli commented Jul 26, 2013

Related issue in clawpack/clawutil#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants