Recursive Call Error with Specific Source Specification

[mandli]

I am not exactly sure why yet but occasionally the new Makefile formats are leading to errors that look like the following:

Errors from Test Advection2DBoundaryTest
Started 2016/02/21-20:56.50
================================================================================
At line 5 of file bc2amr.f
Fortran runtime error: Recursive call to nonrecursive procedure 'bc2amr'

I have tracked the problem down to Makefiles that contain replaced source (they specify SOURCE). A make new seems to help but it's not exactly clear what about make new fixes the problem.

[mandli]

My suspicion is that this may be a problem with not including the source mentioned in the excluded source. In other words it might be a bug in the Python script checkSources.py.

[mandli]

Further info, adding the list of files in SOURCE to the EXCLUDE_* seems to correct the problem.

[rjleveque]

It might be a good idea in general to list excluded library routines on the EXCLUDE line so that it's clear when a local routine is replacing a library routine vs. a local routine that's in addition to the library routines.