Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharpClaw reconstruction doesn't provide values in all ghost cells #637

Open
ketch opened this issue Nov 10, 2019 · 0 comments
Open

SharpClaw reconstruction doesn't provide values in all ghost cells #637

ketch opened this issue Nov 10, 2019 · 0 comments

Comments

@ketch
Copy link
Member

ketch commented Nov 10, 2019

The high-order WENO routines in SharpClaw don't bother to reconstruct in all ghost cells, because the full algorithm doesn't require reconstructed values there. Riemann problems only need to be solved at interfaces that lie within the (closed) physical domain. However, in the Classic algorithm one needs to solve Riemann problems at certain ghost interfaces in order to have the waves needed for the limiter. So the Riemann solvers are written to loop over those ghost interfaces.

This means that with SharpClaw, some Riemann solves are done at ghost interfaces where the inputs (ql, qr) are uninitialized. This usually doesn't cause problems since we don't ever use the output from those Riemann problems. But, for instance, if one is checking the physical correctness of values within the Riemann solver, this can cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant