Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multilayer SW solver requires dgesv #146

Open
rjleveque opened this issue Nov 20, 2018 · 5 comments
Open

multilayer SW solver requires dgesv #146

rjleveque opened this issue Nov 20, 2018 · 5 comments

Comments

@rjleveque
Copy link
Member

Running nose tests on a new AWS EC2 instance revealed this issue in rpn2_layered_shallow_water.f90

lapack is required or at least the subroutine dgesv and any dependencies:

@mandli
Copy link
Member

mandli commented Nov 20, 2018

Are you thinking we should fall-back to directly compiled source for the routine? We definitely do not want to usually do this.

@rjleveque
Copy link
Member Author

Yes, best to use lapack if available. But we could provide something like we do for this example:
https://github.com/clawpack/apps/blob/master/fvmbook/chap17/advdiff/tridiag.f

@mandli
Copy link
Member

mandli commented Nov 21, 2018

So we would need to come up with some sort of check to see if we can link against a native LAPACK. Obviously a configure could do this so we probably need to come up with something similar.

@rjleveque
Copy link
Member Author

Or should we just cleanly skip this unit test if lapack isn't available, as happens with the netCDF tests?

@mandli
Copy link
Member

mandli commented Nov 26, 2018

Might be easiest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants