Add VCN support #141
Comments
|
Rembrandt(VCN 3.0) here, tell me if I can help you |
|
Hi @GreyXor, more testers are always more help! What you can do immediately is delete the Line 374 in e3bbf06 What I am blocked on is more validation and assurance that this or something else is the correct register and is safe for the GPU. Each documentation PDF is ~300 pages long and someone else needs to read time if you want this done faster. I am looking for a citation to evidence documenting the old UVD/VCE registers, and a citation to evidence documenting to new VCN registers. This could either be from the documentation or a mailing list post by someone reliable. |
|
Well, for now when I execute radontop from latest master commit, all my Arch Linux is freezing |
|
Oh no! Userspace shouldn't be able to freeze the system.
|
|
|
I just tested on Navi23. My system didn't crash at all, but this might be because I'm on discrete while you're on integrated. UVD and VCE were both stuck at 0. I tested in Firefox and they were stuck there even on AV1. I still have no clue what the register is supposed to be at. |
You can help by filing a kernel bug report as suggested by #87 (comment) . I think your issue is covered by #87 not the new video code. |
|
Running Linux 6.1.0-rc4 on gentoo here, radeontop causes amdgpu to crash as well, rendering the system unusable. However, I did the same test on 6.0.0 daily builds from ubuntu and 5.15 binary kernels from gentoo, both with success, but quite surprisingly not on 6.0.0-rc4 (gentoo). Edit: |
|
I found a hardware error after installing https://kernel.ubuntu.com/~kernel-ppa/mainline/v6.1-rc4/ . I ran `dmesg` after rebootingHere are the relevant lines: My dual monitors and my backlit keyboard turned black. There is still no indication this is an amdgpu or a radeontop problem. I could do serial debugging but I doubt it's worth the time because it's a machine check error which might not even leave a dmesg or kernel log. |
|
I turns out this also affects ubuntu kernel 5.19.0-21.21. Both this and the other kernel, it never happens immediately. It's probably a race condition with memory mapping. I'm on Navi23 with X570 socket CPU. I have PCI atomics and AMD IOMMU active. dmesg after rebootNormal radeontop without I ran it a third time with The other issue mentions kernel 5.2. The main thing I see there is BACO which is power saving, which has a reputation of causing problems even with other things like USB. I added |
|
build from git with detect patched UVD and VCE always 100% |
|
After digging some time I got something looking at https://github.com/torvalds/linux/blob/fff5a5e7f528b2ed2c335991399a766c2cf01103/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_3_0_0_offset.h#LL796C16-L796C23 I got while running ffmpeg transcode and while playing video on chromium Device: steam deck/vangogh/rdna2 |
This looks like a value PCI is returning when it can't connect to the GPU. Things like this might crash people's computers again. |
|
Should be for all VCN 3 based cores, maybe deadbeef the value set by default by the driver when core not used, also found this |
I think it depends on the Linux Kernel version. |
|
To check VCN status, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The UVDVCE support in #140 did not enable VCN support. In #29 (comment) I explained why not. It is requested by @userofryzen in #29 (comment) .
This is because I don't know if UVD and VCN use the same registers. If they are the same then the PR will be easy and simple. If they are different then someone needs to go and find the documentation that defines where the VCN usage register in located. I have a Navi2 card arriving in about 1 week, so I might look into this if I decide to use that card for video.
The text was updated successfully, but these errors were encountered: