Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on git for getting the version name #150

Open
danielzgtg opened this issue Jan 4, 2023 · 2 comments
Open

Stop relying on git for getting the version name #150

danielzgtg opened this issue Jan 4, 2023 · 2 comments

Comments

@danielzgtg
Copy link
Contributor

Downstream wants us to do this:

It's not a packaging problem, it's an upstream bug:

The version number is set through the script "getver.sh" which is part of the upstream source tree [1]. Since this script exclusively relies on git to determine the version number and the Debian package is built from the distributed tarball which does not contain any git repository information, there is no way for "getver.sh" to determine the version information from the distributed tarball source.

In order to fix this problem, the upstream developers need to modify the Makefile to generate the version information and write it into "getver.sh" anytime "make dist" is called.

Please report this bug upstream, it's not a packaging bug. Also, the original package is maintained in Debian, not Ubuntu which is why it took a bit longer until me (the package maintainer) saw this bug report.

https://bugs.launchpad.net/ubuntu/+source/radeontop/+bug/1992262

@clbr
Copy link
Owner

clbr commented Jan 4, 2023

There is no distributed tarball. There was, years ago, but github removed the files option. If they use a third-party-generated git checkout, that is not an official released tarball by us.

@clbr
Copy link
Owner

clbr commented Jan 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants