Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results have same item #61

Open
two-pack opened this issue Nov 25, 2018 · 4 comments
Open

Search results have same item #61

two-pack opened this issue Nov 25, 2018 · 4 comments

Comments

@two-pack
Copy link
Contributor

Search results have same item when some fields match keyword of searching.
But I think to show only one item on search results.

How to reproduce

  1. Add custom fields for issue.
  2. Create new issue, and set test-keyword to Description and your custom fields.
  3. Search with test-keyword. Searching results has same item of your issue.

Example
I attach my case's screenshot.
My custom fields are cf1 and cf2 and searching keyword is Results.
3 items, issue 5, are on the list, but I think the list should have only a item.
screenshot_search_results

In Japanese,
説明とカスタムフィールドなど、検索される要素にそれぞれ検索キーワードが含まれる場合、同じチケットなどが複数列挙されます。検索結果としては、同じチケットが複数表示されない方が良いと思いますがいかがでしょうか?

@kou
Copy link
Member

kou commented Nov 26, 2018

It makes sense.
We shouldn't show the same issue multiple times. It's better that we put sub search result items for the issue like Google did:

google-sub-items

@two-pack
Copy link
Contributor Author

I'm glad to see your comment.
IMHO, Google's example is not appropriate in this case, because all items are the same link and It does not matter which field matches it.
So I think the first result is enough.

@kou
Copy link
Member

kou commented Nov 30, 2018

Ah, sorry. The example isn't good.
I just want to say that it's better that we also show custom fields values too instead of just showing the ticket description.

@two-pack
Copy link
Contributor Author

I got it. It sounds good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants