Merge pull request #6 from clear-street/tdubey-fix-null-field

Draft: Avro Backwards Transitive Null check
clear-street · Sep 28, 2020 · 7b0f6bf · 7b0f6bf
2 parents 6ea6867 + e1e1903
commit 7b0f6bf
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/avrogen/core_writer.py b/avrogen/core_writer.py
@@ -127,7 +127,12 @@ def write_setters(record, writer, use_logical_types=False):
 
     writer.write('if set(inner_dict.keys()) - set(field_names):\n')
     writer.write('    err = set(inner_dict.keys()) - set(field_names)\n')
-    writer.write('    raise KeyError(f"Keys from provided object are not subset of object params in {type(self).__name__}: {err}")\n')
+    writer.write('    test_keys = []\n')
+    writer.write('    for e in err:\n')
+    writer.write('        if inner_dict[e] is not None:\n')
+    writer.write('            test_keys.append(e)\n')
+    writer.write('    if test_keys:\n')
+    writer.write('        raise KeyError(f"Keys from provided object are not subset of object params in {type(self).__name__}: {err}")\n')
 
     for field in record.fields:
         f_name = field.name