Merge upstream fix for array/slice support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using `AddReflected` or `AppendReflected` with an array or slice. It also resolves an issue where using `AddReflected` would invoke `Elem()` on the reflected value which was an illegal usage of this function and would cause a panic. If it hadn't caused a panic, it would have likely resulted in an infinite loop anyway. This also refactors the code slightly so `AddReflected` and `AppendReflected` no longer have duplicate code and `AppendReflected` is the primary section of code.
…-panic Add array/slice support for reflected values
anishjayavant
approved these changes
Aug 14, 2024
|
We'll need to create a new version tag once this is done - I don't think cicd will do it; @anishjayavant can you or someone in infra do this once this is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream fixed issue where zap-logfmt would panic when attempting to log an array/slice value