From bbe0148f3484e76a82192d1725c4e371e4185cd2 Mon Sep 17 00:00:00 2001 From: Haris Chaniotakis Date: Tue, 30 Jan 2024 17:04:02 +0200 Subject: [PATCH] feat!: When creating a SAML Connection you are also required to provide the provider type We update our SAML Connection Create() method in order to also require the 'provider' property as Backend API from now on requires to be present. This is a breaking change as it concerns the API, but the SAML feature is still in Beta --- clerk/saml_connections.go | 1 + clerk/saml_connections_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/clerk/saml_connections.go b/clerk/saml_connections.go index 12c2cca5..9efe85bb 100644 --- a/clerk/saml_connections.go +++ b/clerk/saml_connections.go @@ -81,6 +81,7 @@ func (s SAMLConnectionsService) Read(id string) (*SAMLConnection, error) { type CreateSAMLConnectionParams struct { Name string `json:"name"` Domain string `json:"domain"` + Provider string `json:"provider"` IdpEntityID *string `json:"idp_entity_id,omitempty"` IdpSsoURL *string `json:"idp_sso_url,omitempty"` IdpCertificate *string `json:"idp_certificate,omitempty"` diff --git a/clerk/saml_connections_test.go b/clerk/saml_connections_test.go index f0234c6a..388b9d0b 100644 --- a/clerk/saml_connections_test.go +++ b/clerk/saml_connections_test.go @@ -93,6 +93,7 @@ func TestSAMLConnectionsService_Create(t *testing.T) { createParams := &CreateSAMLConnectionParams{ Name: "Testing SAML", Domain: "example.com", + Provider: "saml_custom", IdpEntityID: stringToPtr("test-idp-entity-id"), IdpSsoURL: stringToPtr("https://example.com/saml/sso"), IdpCertificate: stringToPtr(dummySAMLConnectionCertificate),