Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should not depend on rustup #1971

Open
bfops opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1996
Open

CLI should not depend on rustup #1971

bfops opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1996
Assignees

Comments

@bfops
Copy link
Collaborator

bfops commented Nov 8, 2024

Phoebe: A small but meaningful subset of users (myself included) use Rust without rustup. Currently, this is painful, because the CLI unconditionally invokes rustup to ensure the wasm32-unknown-unknown target is installed. I ended up having to put a stub shell script into my path as rustup which does nothing and returns 0.

The CLI should verify that cargo has the wasm32-unknown-unknown target installed, and if it is present, not invoke rustup.

Bonus points if the CLI checks for rustup on the system when wasm32-unknown-unknown is not present, and if neither the target nor rustup are present, prints an error message telling the user to install the target.

@gefjon gefjon assigned mamcx and unassigned coolreader18 Nov 12, 2024
@mamcx mamcx linked a pull request Nov 14, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants