Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Combine the defcustoms for the different environments into alists #161

Open
bbatsov opened this issue Mar 23, 2019 · 0 comments
Labels
good first issue Friendly for first time contributors help wanted

Comments

@bbatsov
Copy link
Member

bbatsov commented Mar 23, 2019

Follow up from a discussion in #160. It'd be much better that instead of 4 variables for each environment we support we had just one and it was an alist mapping for each environment. E.g. something like:

(defvar inf-clojure-completion-form 
    '((clj . "foo")
      (lumo . "bar")
      (joker . "baz")))

This would also simplify a lot choosing the right form for an environment as we'd just be able to get the form for the current type without having to use a pcase.

@bbatsov bbatsov added help wanted good first issue Friendly for first time contributors labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Friendly for first time contributors help wanted
Projects
None yet
Development

No branches or pull requests

1 participant