Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional payload options #22

Open
farski opened this issue Jul 10, 2015 · 4 comments
Open

Additional payload options #22

farski opened this issue Jul 10, 2015 · 4 comments

Comments

@farski
Copy link

farski commented Jul 10, 2015

There are some additional parameters that can be sent along with the payload (link_names, mrkdwn, etc), that currently get stripped out because the payload is being built explicitly. Would it be possible to make it so those options could get passed along?

@kevinburkeshyp
Copy link
Collaborator

hey! I believe you can do this... doesn't https://github.com/clonn/slack-node-sdk/blob/master/src/lib/slack.seed.coffee#L77 set any options you pass through on the request?

@farski
Copy link
Author

farski commented Oct 18, 2015

@kevinburkeshyp I think maybe that works with the API but not webhooks, because only certain keys are being added to the payload https://github.com/clonn/slack-node-sdk/blob/master/src/lib/slack.seed.coffee#L36

@strix
Copy link

strix commented Jan 29, 2016

I agree with @farski. In my case, I want to override the unfurl_links option.

@simonrand
Copy link

simonrand commented Jun 29, 2017

+1 from me also, for now I've forked and added these options (master...simonrand:allow_unfurl_options) but would be nice to have this upstream..

(Not sure my changes are worth a PR? A little unclear how to add tests for these options..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants