From 11c37c72cd4d0024c408477d0a10bf728bcb735b Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 28 Oct 2022 00:19:54 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- models/VoT/bert_utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/models/VoT/bert_utils.py b/models/VoT/bert_utils.py index 95b8798..67f69da 100644 --- a/models/VoT/bert_utils.py +++ b/models/VoT/bert_utils.py @@ -391,7 +391,26 @@ def from_pretrained(cls, pretrained_model_name_or_path, *inputs, **kwargs): "extracting archive file {} to temp dir {}".format(resolved_archive_file, tempdir) ) with tarfile.open(resolved_archive_file, "r:gz") as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, tempdir) serialization_dir = tempdir # Load config config_file = os.path.join(serialization_dir, CONFIG_NAME)