Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a new indexer rather than a pointer to the same object #45

Merged

Return a new indexer rather than a pointer to the same object

f1af848
Select commit
Loading
Failed to load commit list.
Merged

Return a new indexer rather than a pointer to the same object #45

Return a new indexer rather than a pointer to the same object
f1af848
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 29, 2024 in 0s

85.41% (-0.75%) compared to ec99247

View this Pull Request on Codecov

85.41% (-0.75%) compared to ec99247

Details

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.41%. Comparing base (ec99247) to head (f1af848).

Files Patch % Lines
indexers/factory.go 81.81% 2 Missing ⚠️
indexers/opensearch.go 77.77% 2 Missing ⚠️
indexers/elastic.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   86.15%   85.41%   -0.75%     
==========================================
  Files           6        6              
  Lines         289      288       -1     
==========================================
- Hits          249      246       -3     
- Misses         26       28       +2     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.