Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to install requirements for each python version #12

Closed
wants to merge 2 commits into from

Conversation

paigerube14
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Want to be able to test the requirements installation on each of the python versions specified to be sure it is usable for specific python versions

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@paigerube14
Copy link
Collaborator Author

@jtaleric @shashank-boyapally PTAL

@paigerube14
Copy link
Collaborator Author

Would pylint really catch different issues per python version? Should we have that run on 1 python version and do the installation of requirements on each of the versions instead?

@paigerube14
Copy link
Collaborator Author

Shashank added this functionality to his pr to validate proper installation in his new integration, closing this

@paigerube14 paigerube14 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant