Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the Makefile & GHA #93

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Updates to the Makefile & GHA #93

merged 4 commits into from
Nov 29, 2023

Conversation

krishvoor
Copy link
Member

@krishvoor krishvoor commented Nov 9, 2023 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This PR will users to pull architecture-specific binaries
instead of always pulling x86 binaries

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@krishvoor
Updates to Makefile & GHA
bbcb72f 
This PR will users to pull architecture specific binaries
instead of always pulling  x86 binaries

Signed-off-by: Krishna Harsha Voora <[email protected]>
@krishvoor
Update to the GHA Actions
a367216
@krishvoor krishvoor mentioned this pull request Nov 9, 2023
Merged
7 tasks
@krishvoor
Copy link
Member Author

Hi @smalleni 👋 can you ptal?

chentex
chentex approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vishnuchalla
vishnuchalla approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit 39a58bd into cloud-bulldozer:master Nov 29, 2023
2 checks passed
@krishvoor krishvoor deleted the makefile-updates branch January 11, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@chentex chentex chentex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishvoor @chentex @vishnuchalla