-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding API-Performance-Overview Dashboard to grafonnet. #97
Adding API-Performance-Overview Dashboard to grafonnet. #97
Conversation
Current Dashboard: Api-Performance dashboard Jsonnet Coded Dashboard: Api-perfromance dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Thanks for this PR @Manda-supraja26 ! I use this dashboard a lot and I would like the panel legends to have "Max" instead of "Last *". That's a change I make in my own dashboard copies because "Current" doesn't give me the information I want. Also, if the Tooltips can "sort descending" that is also more helpful when there are usually large numbers of data series in one panel. |
Thanks for the review @afcollins. i will work on suggested changes. |
@afcollins I have updated the dashboard. Please let me know if anything needs to be added. Dashboard links:
|
@Manda-supraja26 I think its good to confirm that moving all the legends from "current" --> "max" is okay with all the users and is backward compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks :)
Type of change
Description
Adding API-Performance Dashboard to grafonnet
Related Tickets & Documents
Checklist before requesting a review
Testing