Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding API-Performance-Overview Dashboard to grafonnet. #97

Merged
merged 12 commits into from
Feb 7, 2024

Conversation

smandaRH
Copy link
Collaborator

@smandaRH smandaRH commented Dec 6, 2023

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding API-Performance Dashboard to grafonnet

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@smandaRH smandaRH self-assigned this Dec 6, 2023
@smandaRH smandaRH added the enhancement New feature or request label Dec 6, 2023
@smandaRH
Copy link
Collaborator Author

smandaRH commented Jan 9, 2024

Current Dashboard: Api-Performance dashboard

Jsonnet Coded Dashboard: Api-perfromance dashboard

@vishnuchalla
Copy link
Collaborator

label names and values doesn't seem to be matching exactly. Can you make sure that everything between the old and new dashboards is same.

Screenshot 2024-01-19 at 9 32 05 AM Screenshot 2024-01-19 at 9 32 06 AM

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@afcollins
Copy link
Member

Thanks for this PR @Manda-supraja26 ! I use this dashboard a lot and I would like the panel legends to have "Max" instead of "Last *". That's a change I make in my own dashboard copies because "Current" doesn't give me the information I want.

Also, if the Tooltips can "sort descending" that is also more helpful when there are usually large numbers of data series in one panel.

@smandaRH
Copy link
Collaborator Author

Thanks for this PR @Manda-supraja26 ! I use this dashboard a lot and I would like the panel legends to have "Max" instead of "Last *". That's a change I make in my own dashboard copies because "Current" doesn't give me the information I want.

Also, if the Tooltips can "sort descending" that is also more helpful when there are usually large numbers of data series in one panel.

Thanks for the review @afcollins. i will work on suggested changes.

@smandaRH
Copy link
Collaborator Author

smandaRH commented Feb 1, 2024

@vishnuchalla
Copy link
Collaborator

@afcollins I have updated the dashboard. Please let me know if anything needs to be added. Dashboard links:

@vishnuchalla
old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/mniWpfpSk/api-performance?orgId=1&refresh=30s
new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/T6kZpftIk/api-performance-dashboard?orgId=1&refresh=30s

@Manda-supraja26 I think its good to confirm that moving all the legends from "current" --> "max" is okay with all the users and is backward compatible.

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks :)

@vishnuchalla vishnuchalla merged commit bdc7b01 into cloud-bulldozer:master Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants