Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Why is analytics for cg-site in this repo? #338

Open
rogeruiz opened this issue Oct 19, 2018 · 0 comments
Open

Why is analytics for cg-site in this repo? #338

rogeruiz opened this issue Oct 19, 2018 · 0 comments

Comments

@rogeruiz
Copy link
Contributor

I don't think that the hard-coded Google Analytics code should exist in this repo. It requires a release of this package in order to update any of that code. And the level of indirection here makes it hard for less technically-savvy folks to determine the proper order of operations and exact steps to update it.

I propose that we can remove it from this repo and add it as a layouts/partial/*.html in the cg-site repository instead.

💭 thoughts welcome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant