Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set correct mandatory require_signed_commits value #63

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

set correct mandatory require_signed_commits value #63

wants to merge 13 commits into from
+66 −26

Conversation

lixhunter
Copy link
Collaborator

No description provided.

@lixhunter lixhunter self-assigned this Nov 25, 2024
@lixhunter lixhunter marked this pull request as draft November 26, 2024 10:15
@lixhunter lixhunter added the bug Something isn't working label Nov 26, 2024
@lixhunter lixhunter marked this pull request as ready for review November 26, 2024 11:39
rswrz
rswrz reviewed Nov 26, 2024
View reviewed changes
terraform/module-repo-setup.tf
Comment on lines +49 to +51
ARM_CLIENT_ID : var.ARM_CLIENT_ID
ARM_SUBSCRIPTION_ID : var.ARM_SUBSCRIPTION_ID
ARM_TENANT_ID : var.ARM_TENANT_ID
Copy link
Member

@rswrz rswrz Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the assignment have equal signs? Colon does work, but does not get recognized by terraform fmt.

Suggested change
ARM_CLIENT_ID : var.ARM_CLIENT_ID
ARM_SUBSCRIPTION_ID : var.ARM_SUBSCRIPTION_ID
ARM_TENANT_ID : var.ARM_TENANT_ID
ARM_CLIENT_ID = var.ARM_CLIENT_ID
ARM_SUBSCRIPTION_ID = var.ARM_SUBSCRIPTION_ID
ARM_TENANT_ID = var.ARM_TENANT_ID

@lixhunter lixhunter deployed to Terraform (Plan) November 26, 2024 15:10 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswrz rswrz rswrz left review comments

@Phil-Thoennissen Phil-Thoennissen Awaiting requested review from Phil-Thoennissen Phil-Thoennissen is a code owner

@neonwhiskers neonwhiskers Awaiting requested review from neonwhiskers neonwhiskers is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@lixhunter lixhunter

Labels
bug Something isn't working
Projects
Terraform Module Development
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixhunter @rswrz