Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support admin code override #2797

Merged

Conversation

da-cf
Copy link
Contributor

@da-cf da-cf commented Jul 30, 2024

Support the admin override code feature. Will be making a PR in the Terraform Provider to also support this feature.

Has your change been tested?

Yes. Added tests to the existing teams_accounts_test.go file.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X ] I have added tests to cover my changes.
  • [ X ] All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs. (Internal PR will be released soon)

@da-cf da-cf requested a review from jacobbednarz as a code owner July 30, 2024 22:07
Copy link
Contributor

github-actions bot commented Jul 30, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

lgtm, ping me when we land the docs and i'll get this merged.

@da-cf
Copy link
Contributor Author

da-cf commented Aug 12, 2024

lgtm, ping me when we land the docs and i'll get this merged.

The docs have been merged :)

@jacobbednarz jacobbednarz merged commit 30dac60 into cloudflare:master Aug 14, 2024
6 of 9 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Aug 14, 2024
github-actions bot pushed a commit that referenced this pull request Aug 14, 2024
Copy link
Contributor

This functionality has been released in v0.102.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants