Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly opt out of taskprov tasks #710

Closed
mendess opened this issue Oct 31, 2024 · 2 comments · Fixed by #742
Closed

Properly opt out of taskprov tasks #710

mendess opened this issue Oct 31, 2024 · 2 comments · Fixed by #742
Assignees

Comments

@mendess
Copy link
Collaborator

mendess commented Oct 31, 2024

Discussion: #709 (comment)

Relevant spec: https://ietf-wg-ppm.github.io/draft-ietf-ppm-dap-taskprov/draft-ietf-ppm-dap-taskprov.html#section-4.4-3.1.1

We don't reject when a task id does not match the task config

@cjpatton cjpatton self-assigned this Dec 16, 2024
@cjpatton cjpatton added the bug Something isn't working label Dec 18, 2024
@cjpatton
Copy link
Contributor

To clarify: This only happens when we've already configured the task, in which case we use the previously configured task config to handle the request and not the advertised config.

@cjpatton
Copy link
Contributor

Actually, it appears this is already enforced by parse_taskprov_advertisement(), which checks to make sure the task ID was computed properly from the advertised config. #742 adds a regression test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants