Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make sentry optional #397

Closed
Grvzard opened this issue Sep 24, 2024 · 3 comments
Closed

[Feature] Make sentry optional #397

Grvzard opened this issue Sep 24, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Grvzard
Copy link
Contributor

Grvzard commented Sep 24, 2024

If we make sentry an optional feature, the number of dependencies in pingora-core will decrease by around 70+. And it will significantly reduce the size of the binary.

@eaufavor eaufavor added the enhancement New feature or request label Sep 24, 2024
@eaufavor eaufavor self-assigned this Sep 24, 2024
@eaufavor eaufavor added the WIP We are working on this feature internally label Sep 24, 2024
@eaufavor
Copy link
Member

working on this right now

@moderation
Copy link

I'm getting a build error on main after the Sentry option PR #410

env RUST_BACKTRACE=full RUST_LOG=INFO mold --run cargo run --example test --release --no-default-features --features=boringssl
   Compiling pingora-core v0.3.0 (~/Library/rust/pingora/pingora-core)
error[E0433]: failed to resolve: use of undeclared crate or module `sentry`
   --> pingora-core/src/server/mod.rs:122:29
    |
122 | ...                   sentry::capture_error(&e);
    |                       ^^^^^^ use of undeclared crate or module `sentry`

error[E0609]: no field `sentry` on type `&mut Server`
   --> pingora-core/src/server/mod.rs:264:27
    |
264 |         let _guard = self.sentry.as_ref().map(|opts| sentry::init(opts.clone()));
    |                           ^^^^^^ unknown field
    |
    = note: available fields are: `services`, `listen_fds`, `shutdown_watch`, `shutdown_recv`, `configuration`, `options`

error[E0433]: failed to resolve: use of undeclared crate or module `sentry`
   --> pingora-core/src/server/mod.rs:264:54
    |
264 |         let _guard = self.sentry.as_ref().map(|opts| sentry::init(opts.clone()));
    |                                                      ^^^^^^ use of undeclared crate or module `sentry`

error[E0433]: failed to resolve: use of undeclared crate or module `sentry`
   --> pingora-core/src/server/mod.rs:279:17
    |
279 |                 sentry::capture_error(&e);
    |                 ^^^^^^ use of undeclared crate or module `sentry`

error[E0609]: no field `sentry` on type `Server`
   --> pingora-core/src/server/mod.rs:308:27
    |
308 |         let _guard = self.sentry.as_ref().map(|opts| sentry::init(opts.clone()));
    |                           ^^^^^^ unknown field
    |
    = note: available fields are: `services`, `listen_fds`, `shutdown_watch`, `shutdown_recv`, `configuration`, `options`

error[E0433]: failed to resolve: use of undeclared crate or module `sentry`
   --> pingora-core/src/server/mod.rs:308:54
    |
308 |         let _guard = self.sentry.as_ref().map(|opts| sentry::init(opts.clone()));
    |                                                      ^^^^^^ use of undeclared crate or module `sentry`

Some errors have detailed explanations: E0433, E0609.
For more information about an error, try `rustc --explain E0433`.
error: could not compile `pingora-core` (lib) due to 6 previous errors

@Grvzard
Copy link
Contributor Author

Grvzard commented Oct 8, 2024

I'm getting a build error on main after the Sentry option PR #410

#399 (comment)

@eaufavor eaufavor removed the WIP We are working on this feature internally label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants