Fixes #476: Correctly handle URI which contains hostname #477
+12
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detailed explanation in issue #476.
Description
This code fixes #476.
The code is now correctly handling URLs like
http://example.com/favicon.ico
.Previously, because
Uri::builder() .path_and_query(p)
was useduri.host()
would be none andpath_and_query
would be/http://example.com/favicon.ico
.This PR fixes that issue.
After my fix the
host
is nowexample.com
and thepath_and_query
are/favicon.ico
.I've added the
\\
normalization to fix thetest_single_header
andtest_multiple_header
unit tests.