Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #476: Correctly handle URI which contains hostname #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeroenvervaeke
Copy link

See detailed explanation in issue #476.

Description

This code fixes #476.

The code is now correctly handling URLs like http://example.com/favicon.ico.

Previously, because Uri::builder() .path_and_query(p) was used uri.host() would be none and path_and_query would be /http://example.com/favicon.ico.

This PR fixes that issue.
After my fix the host is now example.com and the path_and_query are /favicon.ico.

I've added the \\ normalization to fix the test_single_header and test_multiple_header unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pingora-http incorrectly handling URI with host
3 participants