Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: hyperdrive localConnectionString changed to sslmode=prefer after updated to 3.86.1 #7255

Open
j4tmr opened this issue Nov 14, 2024 · 4 comments
Labels
bug Something that isn't working

Comments

@j4tmr
Copy link

j4tmr commented Nov 14, 2024

Which Cloudflare product(s) does this pertain to?

Wrangler

What version(s) of the tool(s) are you using?

3.86.1

What version of Node are you using?

20.10.0

What operating system and version are you using?

Mac Sonoma 14.6.1

Describe the Bug

Observed behavior

hyperdrive localConnectionString not working
sslmode=disable in 3.85.0

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response

@j4tmr j4tmr added the bug Something that isn't working label Nov 14, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Nov 14, 2024
@j4tmr j4tmr changed the title 🐛 BUG: hyperdrive localConnectionString changeed to sslmode=prefer after updated to 3.86.1 🐛 BUG: hyperdrive localConnectionString changed to sslmode=prefer after updated to 3.86.1 Nov 14, 2024
@edmundhung
Copy link
Member

Hi @j4tmr ! Yes, we’ve updated localConnectionString to use sslmode=prefer recently. This change should allow connections to use SSL if available while still supporting unencrypted connections for local test databases.

If you run into any issues because of this change, could you share more details, such as any error messages you’re seeing? That would help us investigate further. Thanks!

@j4tmr
Copy link
Author

j4tmr commented Nov 19, 2024

@edmundhung The server does not support SSL connections. While i'm using supabase locally, with configuration

[[hyperdrive]]
binding = "xxx"
id = "xxx"
localConnectionString = "postgresql://postgres:[email protected]:54322/postgres"

And at the same time, localConnectionString = "postgresql://postgres:[email protected]:54322/postgres?sslmode=disable" not works.

@sambarnes
Copy link

sambarnes commented Nov 21, 2024

seeing similar as j4tmr -- appears we're both using supabase, judging from the 54322 port number there

this worked previously but no longer does

local workaround is doing this for dev environment:
c.env.HYPERDRIVE_SUPABASE.connectionString.replace('sslmode=prefer', 'sslmode=disable')

not great but unblocks for now


edit: oh and to be clear, error i was seeing was CONNECT_TIMEOUT

@ivanfgm
Copy link

ivanfgm commented Nov 21, 2024

Same here with a remote timescale instance (CONNECT_TIMEOUT), could only get it working replacing prefer with disable same as @sambarnes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
Status: Untriaged
Development

No branches or pull requests

4 participants