Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for preview comment. #77

Open
NorbertBodziony opened this issue Jun 9, 2022 · 14 comments
Open

Feature request: Support for preview comment. #77

NorbertBodziony opened this issue Jun 9, 2022 · 14 comments
Labels
enhancement New feature or request triaged

Comments

@NorbertBodziony
Copy link

Would love to get support for preview comment after successful deployment.
Something like this https://github.com/BetaHuhn/deploy-to-vercel-action for vercel.

@NullVoxPopuli
Copy link

Or maybe like Cloudflare Pages?

example: NullVoxPopuli/ember-resources#529

image

@GrantBirki
Copy link
Contributor

Yes please! This feature would be awesome. Or even a way for us to construct that message via exported values. This Action currently takes inputs but does not save any outputs.

I tried to manually construct this message by saving the .stdout of this Action but no luck. This feature would be greatly appreciated

@adam-clio
Copy link

Came here to request this feature. Even some output from this action would be awesome so we could create our own comments

@danawoodman
Copy link

Hate to be "that guy", but can we get a bumpbump on this bad boy? Kinda makes this action worthless for PR deploys at this point.

Also, seems related to #90 #81

@NorbertBodziony
Copy link
Author

Hey @JacobMGEvans can you provide more info why this issue has been closed ?

@JacobMGEvans JacobMGEvans reopened this Aug 8, 2023
@JacobMGEvans
Copy link
Contributor

JacobMGEvans commented Aug 8, 2023

I closed them all (#122), this sounds like a great idea. Will revisit it, thanks for the follow up!

@JacobMGEvans
Copy link
Contributor

If it Pages related I suggest this comment as well to help #65 (comment)

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 28, 2023
@admah admah added the enhancement New feature or request label Oct 30, 2023
@hellt
Copy link

hellt commented Jul 25, 2024

It would be great if wrangler action would provide the same bot functionality as shown by the OP.

@srl295
Copy link

srl295 commented Aug 27, 2024

@hellt
Copy link

hellt commented Aug 28, 2024

This is sweet, thanks @srl295
The missing piece, though, is having an alias with the branch name, which seems to be totally gone when the static artifacts are pushed via wrangler and not via the direct repo integration

@srl295
Copy link

srl295 commented Aug 28, 2024

This is sweet, thanks @srl295 The missing piece, though, is having an alias with the branch name, which seems to be totally gone when the static artifacts are pushed via wrangler and not via the direct repo integration

I'm not 24 hours into my integration at this point, so.. I don't quite follow what you mean. You want "mysite-mybranch.pages.dev" or something? I don't quite see how that's part of this issue - that sounds like an option on the upload side?

@hellt
Copy link

hellt commented Aug 28, 2024

You want "mysite-mybranch.pages.dev" or something? I don't quite see how that's part of this issue - that sounds like an option on the upload side?

Yes, this is about Branch Prefiew URL as shown in #77 (comment)

I agree, it might be considered not related to the request of having ability for an action to post a comment, if we only consider comment to have a hash-based preview URL that is visible in the action output.

@srl295
Copy link

srl295 commented Aug 28, 2024

the current action produces a single URL as output. So it seems like something else is needed if you want a different URL. Maybe you should file a separate issue for it?

@ve1997
Copy link

ve1997 commented Nov 13, 2024

I'm also looking for this feature.
I had no choice but to write my own workflow, so there's no problem, but if it's officially supported, that would be best.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests