Merge pull request #5282 from WANZARGEN/master

fix(task-management): remove unnecessary scope from sharedConfigStore call
cloudforet-io · Dec 20, 2024 · d5fb2b1 · d5fb2b1
2 parents 7b9db79 + 5e209bc
commit d5fb2b1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/apps/web/src/services/ops-flow/components/TaskContentBaseForm.vue b/apps/web/src/services/ops-flow/components/TaskContentBaseForm.vue
@@ -78,8 +78,8 @@ const handleUpdateSelectedTaskType = async (items: SelectDropdownMenuItem[]) =>
     await taskContentFormStore.setCurrentTaskType(items[0].name); // set current task type to store for other fields
     const taskType = taskContentFormState.currentTaskType;
     const category = taskContentFormGetters.currentCategory;
-    if (items.length > 0 && (!category || !taskType)) {
-        ErrorHandler.handleError(new Error('Failed to get category or task type'));
+    if (items.length > 0 && !category) {
+        ErrorHandler.handleError(new Error('Failed to get category'));
         return;
     }
     if (category && taskType) {

diff --git a/...b/src/services/ops-flow/task-fields-configuration/stores/use-task-field-metadata-store.ts b/...b/src/services/ops-flow/task-fields-configuration/stores/use-task-field-metadata-store.ts
@@ -33,7 +33,6 @@ export const useTaskFieldMetadataStore = defineStore('task-field-metadata', () =
             getters.taskFieldTypeMetadataMap.LABELS,
             getters.taskFieldTypeMetadataMap.DROPDOWN,
             getters.taskFieldTypeMetadataMap.DATE,
-            getters.taskFieldTypeMetadataMap.ASSET,
             getters.taskFieldTypeMetadataMap.PROJECT,
         ]),
         defaultFields: computed<TaskField[]>(() => [

diff --git a/.../services/ops-flow/task-management-templates/stores/use-task-management-template-store.ts b/.../services/ops-flow/task-management-templates/stores/use-task-management-template-store.ts
@@ -86,7 +86,7 @@ export const useTaskManagementTemplateStore = defineStore('task-management-templ
         const prev = state.templateId;
         state.templateId = templateId;
         try {
-            await sharedConfigStore.set<TemplateData>('TASK_TEMPLATE', { template_id: templateId }, 'DOMAIN');
+            await sharedConfigStore.set<TemplateData>('TASK_TEMPLATE', { template_id: templateId });
             showSuccessMessage(i18n.t('OPSFLOW.ALT_S_EDIT_TARGET', { target: i18n.t('OPSFLOW.TASK_MANAGEMENT.TEMPLATE_TYPE') }), '');
         } catch (e) {
             ErrorHandler.handleRequestError(e, i18n.t('OPSFLOW.ALT_E_EDIT_TARGET', { target: i18n.t('OPSFLOW.TASK_MANAGEMENT.TEMPLATE_TYPE') }));