From 2e10b701e4243b562e5f630868b7e2e59dba0f4e Mon Sep 17 00:00:00 2001 From: "NaYeong,Kim" Date: Wed, 20 Nov 2024 10:31:59 +0900 Subject: [PATCH 01/10] fix: fixed feedback bug (#5058) * feat: apply PHeadingLayout Signed-off-by: NaYeong,Kim * fix: fixed text clipping on select dropdown button Signed-off-by: NaYeong,Kim --------- Signed-off-by: NaYeong,Kim --- .../CollectorDetailSectionHeader.vue | 18 ++++++----- .../components/DataSourceManagementModal.vue | 13 ++++++-- .../DataSourceManagementTabLinkedAccount.vue | 32 +++++++++---------- .../services/info/components/NoticeForm.vue | 5 +++ .../services/info/components/NoticeList.vue | 8 ++++- .../components/NoticeWorkspaceDropdown.vue | 10 +++++- .../LandingWorkspaceGroupTabGroupUser.vue | 6 +++- 7 files changed, 62 insertions(+), 30 deletions(-) diff --git a/apps/web/src/services/asset-inventory/components/CollectorDetailSectionHeader.vue b/apps/web/src/services/asset-inventory/components/CollectorDetailSectionHeader.vue index 62667bac53..2bd93ad870 100644 --- a/apps/web/src/services/asset-inventory/components/CollectorDetailSectionHeader.vue +++ b/apps/web/src/services/asset-inventory/components/CollectorDetailSectionHeader.vue @@ -3,7 +3,7 @@ import { useWindowSize } from '@vueuse/core'; import type { TranslateResult } from 'vue-i18n'; import { - PButton, PHeading, PIconButton, screens, + PButton, PHeading, PIconButton, screens, PHeadingLayout, } from '@cloudforet/mirinae'; const props = defineProps<{ @@ -24,12 +24,14 @@ const handleClickEdit = () => { diff --git a/apps/web/src/services/cost-explorer/components/DataSourceManagementModal.vue b/apps/web/src/services/cost-explorer/components/DataSourceManagementModal.vue index 593ca6e518..7ec5d4cf69 100644 --- a/apps/web/src/services/cost-explorer/components/DataSourceManagementModal.vue +++ b/apps/web/src/services/cost-explorer/components/DataSourceManagementModal.vue @@ -149,6 +149,7 @@ const workspaceMenuHandler: AutocompleteHandler = async (inputText: string, page :search-text.sync="dropdownState.searchText" show-select-marker is-filterable + is-fixed-width :handler="workspaceMenuHandler" class="workspace-select-dropdown" @select="handleSelectDropdownItem" @@ -161,7 +162,7 @@ const workspaceMenuHandler: AutocompleteHandler = async (inputText: string, page :theme="getWorkspaceInfo(dropdownState.selectedMenuId)?.tags?.theme" size="xs" /> - {{ getWorkspaceInfo(dropdownState.selectedMenuId)?.name || '' }} + {{ getWorkspaceInfo(dropdownState.selectedMenuId)?.name || '' }} - {{ item.label }} + {{ item.label }} @@ -202,7 +203,11 @@ const workspaceMenuHandler: AutocompleteHandler = async (inputText: string, page .workspace-select-dropdown { .workspace-wrapper { @apply flex items-center; + width: 100%; gap: 0.25rem; + .label { + @apply truncate; + } } .select { @apply text-gray-600; @@ -221,6 +226,10 @@ const workspaceMenuHandler: AutocompleteHandler = async (inputText: string, page @apply bg-gray-300; } } + .label { + @apply truncate; + max-width: 21rem; + } .description { @apply text-label-md text-gray-500; } diff --git a/apps/web/src/services/cost-explorer/components/DataSourceManagementTabLinkedAccount.vue b/apps/web/src/services/cost-explorer/components/DataSourceManagementTabLinkedAccount.vue index b7f4472979..652bc38a96 100644 --- a/apps/web/src/services/cost-explorer/components/DataSourceManagementTabLinkedAccount.vue +++ b/apps/web/src/services/cost-explorer/components/DataSourceManagementTabLinkedAccount.vue @@ -9,7 +9,7 @@ import { getApiQueryWithToolboxOptions } from '@cloudforet/core-lib/component-ut import type { ConsoleFilter } from '@cloudforet/core-lib/query/type'; import { ApiQueryHelper } from '@cloudforet/core-lib/space-connector/helper'; import { - PButton, PHeading, + PButton, PHeading, PHeadingLayout, } from '@cloudforet/mirinae'; import type { ToolboxOptions } from '@cloudforet/mirinae/types/controls/toolbox/type'; @@ -152,14 +152,16 @@ onUnmounted(() => {