Merge pull request #55 from junho100/master

Update dictionary key check
cloudforet-io · Aug 19, 2024 · ca46e1e · ca46e1e
2 parents 88283da + 8383de8
commit ca46e1e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/plugin/manager/email/category_manager.py b/src/plugin/manager/email/category_manager.py
@@ -37,7 +37,7 @@ def create_cloud_service(self, secret_data):
         category_connector = CategoryConnector()
 
         categories = []
-        if hasattr(secret_data, "email_secret_key"):
+        if "email_secret_key" in secret_data:
             categories = category_connector.list_categories(secret_data.get("app_key"), secret_data.get("email_secret_key"))
 
         for category in categories:

diff --git a/src/plugin/manager/email/tag_manager.py b/src/plugin/manager/email/tag_manager.py
@@ -37,7 +37,7 @@ def create_cloud_service(self, secret_data):
         tag_connector = TagConnector()
 
         tags = []
-        if hasattr(secret_data, "email_secret_key"):
+        if "email_secret_key" in secret_data:
             tags = tag_connector.list_tags(secret_data.get("app_key"), secret_data.get("email_secret_key"))
 
         for tag in tags:

diff --git a/src/plugin/manager/email/template_manager.py b/src/plugin/manager/email/template_manager.py
@@ -37,7 +37,7 @@ def create_cloud_service(self, secret_data):
         template_connector = TemplateConnector()
 
         templates = []
-        if hasattr(secret_data, "email_secret_key"):
+        if "email_secret_key" in secret_data:
             templates = template_connector.list_templates(secret_data.get("app_key"), secret_data.get("email_secret_key"))
 
         for template in templates:

diff --git a/src/plugin/manager/push/tag_manager.py b/src/plugin/manager/push/tag_manager.py
@@ -37,7 +37,7 @@ def create_cloud_service(self, secret_data):
         tag_connector = PushTagConnector()
 
         tags = []
-        if hasattr(secret_data, "push_secret_key"):
+        if "push_secret_key" in secret_data:
             tags = tag_connector.list_tags(secret_data.get("app_key"), secret_data.get("push_secret_key"))
 
         for tag in tags:

diff --git a/src/plugin/manager/push/token_manager.py b/src/plugin/manager/push/token_manager.py
@@ -37,7 +37,7 @@ def create_cloud_service(self, secret_data):
         token_connector = PushTokenConnector()
 
         tokens = []
-        if hasattr(secret_data, "push_secret_key"):
+        if "push_secret_key" in secret_data:
             tokens = token_connector.list_tokens(secret_data.get("app_key"), secret_data.get("push_secret_key"))
 
         for token in tokens: