Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base common logic #5

Closed
wants to merge 13 commits into from
Closed

Conversation

junho100
Copy link
Member

@junho100 junho100 commented Jul 5, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Add base common logic for development. Calling manager according to secret type.
Add schema & provider yaml.
resolve #1

junho100 added 4 commits July 5, 2024 23:24
- Add BaseManager, BaseCollector for common base logic
- Add logic calls Managers according to auth(schema) type

Signed-off-by: Junho Baek <[email protected]>
Signed-off-by: Junho Baek <[email protected]>
Signed-off-by: Junho Baek <[email protected]>
Copy link

github-actions bot commented Jul 5, 2024

⚠️ @junho100 the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

github-actions bot commented Jul 5, 2024

⚠️ @junho100 the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
Copy link

github-actions bot commented Jul 6, 2024

⚠️ @junho100 the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

junho100 added 7 commits July 7, 2024 01:03
Signed-off-by: Junho Baek <[email protected]>
- update relative to absolute path

Signed-off-by: Junho Baek <[email protected]>
- modify static data path

Signed-off-by: Junho Baek <[email protected]>
- update misused pk mapping
- delete unused codes

Signed-off-by: Junho Baek <[email protected]>
@choonho
Copy link
Member

choonho commented Jul 8, 2024

Separate per each issue.

@choonho choonho closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create NHN Cloud provider
2 participants