Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Reporting start and end are invalid #802

Open
ghost opened this issue Nov 13, 2017 · 1 comment
Open

Reporting start and end are invalid #802

ghost opened this issue Nov 13, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 13, 2017

Looking at the following section of code:

https://github.com/cloudfoundry-incubator/cf-abacus/blob/87dc920ec237683714668162bbb5a12b495116ba/lib/aggregation/reporting/src/index.js#L757-L767

it seems that start has the semantic of the beginning of the month for which a report is requested and end has the semantic of the timestamp up to which the report is requested, or the current time, in case such a timestamp has not been specified.

However, that code executes only if there is no report to be returned. In the happy path, when a report does exist, we use the start and end of the document in the aggregator that contains the values coming from (what I believe) is the last submitted usage.

We should make start and end consistent, where the former case seems to make more sense.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152798900

The labels on this github issue will be updated when the story is started.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant