Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] App secret names should be valid uuids #3622

Open
danail-branekov opened this issue Nov 20, 2024 · 0 comments
Open

[Chore] App secret names should be valid uuids #3622

danail-branekov opened this issue Nov 20, 2024 · 0 comments
Labels

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Nov 20, 2024

When an app is being reconciled, the app controller creates vcap-application and vcap-services secrets whose names are set to app_name, followed by the -vcap-services and -vcap-application suffixes. This naming convention is quite naive, names should really be uuids. Furthermore, the secret names are stored in the app status, so using naming convention does not really make sense.

Action to take

  • The app controller should set uuid.NewString() (uuidv4) names for those secrets
  • Make sure that such a change does not affect existing apps. It shouldn't as the secret names should be already stored in the app status
@danail-branekov danail-branekov converted this from a draft issue Nov 20, 2024
@danail-branekov danail-branekov added this to the v1.0.0 milestone Nov 20, 2024
@danail-branekov danail-branekov removed this from the v1.0.0 milestone Nov 20, 2024
@danail-branekov danail-branekov changed the title App secret names should be valid uuids [Chore] App secret names should be valid uuids Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🇪🇺 To do
Development

No branches or pull requests

1 participant