-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install fails #1
Comments
I will take a look |
|
Can you remove old node_modules directory and do npm install again? I am not able to reproduce this locally. |
I can see this warning thought WARNING in ./node_modules/jQuery/dist/jquery.js which should be addressed. I will do it. |
We are already adding node-sass in package.json, so it is not required explicitly with npm install in makefile. "node-sass": "^4.11.0" |
This did not work on my machine, I explicitly had to add node-saas I have pretty much a vanilla machine with nothing on it in javascript other than what you provided. |
The other warning seesm to be that some defaults need to be set for running electron so the warning no longer shows. Not sure what and how this has to be done.
|
I will test this inside an ubuntu 18.04 container |
I know how to fix first two warnings. For last three warnings I will try to find something and get back to you. |
Great. Lets collect these issues and address carefully. Are there any other ways to install or bundel them. E.g. I saw lots of bundlers that do allow craetion of dmg, exe and windows command. Do you know if there is a prefered way. I also saw the comment on outoupdate whcih would be cool |
yes I know how to bundle this. For now lets keep make file based installation. I have created separate issue for installation and update. I will start working on it today. we don't need third party bundlers. electronjs provides command to do this. |
commit 800ac1d fixes all warnings. |
I feel there must have been issue with node_modules directory on your machine. If you want to test, you can try removing node_modules folder from app folder and then do We can remove explicit installation of node-sass but if you want we can keep it, as npm will takes care of redundancy in package.json |
Install does not work:
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build:
webpack
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/grey/.npm/_logs/2018-12-21T13_39_14_669Z-debug.log
The text was updated successfully, but these errors were encountered: