-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Release Assets #2
Comments
@zachmandeville can you document where / how you created the tunnel release assets? |
For ii/wgtunnel, I manually created them using go build flags. I set the list of supported GOOS/GOARCH combos and then ran go build for each pair. The second part was uploading it up to the repo, which I did by doing a tag commit, which lets you upload assets for the tag. It was a blunt, manual approach. It would be good to use the existing ci and make tools of this repo, but that is a bit more complicated. I looked into it today, to try to get ourbuild steps working, and the issue is how much coder/wgtunnel is used throughout the ci. The make file, for example, references the tags in It is making me wonder if it would be more useful to be collaborating with the upstream coder team, instead of making a fork of this tool? Are we changing the feature-set of this tool a bunch, or just wanting to build it for multiple targets? If we are wanting to switch over everything to this fork, we'll now be maintaining the tool wgtunnel with the work that entails. I'd like to discuss the ultimate goal, to see if there's an easier way to get this done that invites cooperation across teams and people. |
Yes, we will be pushing this upstream. |
I have created a PR to review / merge and submit upstream. |
Here is the PR I created to address this: https://github.com/coder/wgtunnel/pull/15/files |
I merged the tunnel binary branch into main so it would be easier to test our actions, and found that as long as we are following the versioning flow of coder, the action works and publishes all assets in a list. You can see it now in our release page for v0.1.12 The main thing is that the releases action is expecting an annotated release tag, and this tag should follow semver. If you are not pushing a release tag to main, then the. action won't fire. If you push a tag without annotation, then you will get an error from our scripts/version.sh file. Pushing with an annotation will let Pushing an annotated releaseThis is straightforward in magit. |
@ii generates assets for our tags here:
https://github.com/ii/wgtunnel/releases/tag/v0.1.0
Having trouble generating them here:
https://github.com/cloudnative-coop/wgtunnel/actions/runs/4716351905
Help wanted!
The text was updated successfully, but these errors were encountered: