Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused hashicorp/local provider #66

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

megashby
Copy link
Contributor

@megashby megashby commented Mar 5, 2025

what

  • remove usage of hashicorp/local provider & update examples

why

  • the hashicorp/local provider is not in use
  • the hashicorp/local provider can be used to load files from local machine, when not intended this functionality can cause security concerns

references

@megashby megashby requested review from a team as code owners March 5, 2025 16:38
@megashby megashby requested review from Gowiem and gberenice March 5, 2025 16:38
@mergify mergify bot added the triage Needs triage label Mar 5, 2025
@megashby
Copy link
Contributor Author

megashby commented Mar 5, 2025

/terratest

@megashby
Copy link
Contributor Author

megashby commented Mar 5, 2025

/terratest

@megashby
Copy link
Contributor Author

megashby commented Mar 5, 2025

@Gowiem / @gberenice do I have to do something to get these CI checks to complete?

@Gowiem
Copy link
Member

Gowiem commented Mar 5, 2025

/terratest

@Gowiem
Copy link
Member

Gowiem commented Mar 5, 2025

@megashby as a security measure, you need to be within the contributor team. Otherwise, a brand new contributor could open a PR that creates 1000x cryptominers in the CP AWS account through Terratest and suddenly their bill is a million bucks.

I've just kicked them off for you 👍

@megashby
Copy link
Contributor Author

megashby commented Mar 5, 2025

@megashby as a security measure, you need to be within the contributor team. Otherwise, a brand new contributor could open a PR that creates 1000x cryptominers in the CP AWS account through Terratest and suddenly their bill is a million bucks.

I've just kicked them off for you 👍

Thank you for this @Gowiem! If you could additionally provide guidance on if there is anything else the maintainers would like to see here it would be very appreciated! We really love using this module in our org but due to our new security requirements we are facing issues with the current state and it's inclusion of the unused hashicorp/local provider.

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem Gowiem merged commit 2118651 into cloudposse:main Mar 5, 2025
15 checks passed
@mergify mergify bot removed the triage Needs triage label Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

These changes were released in v1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants