-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .mvn/jvm.config #94
Comments
Can you give some more explanation on when this happens (ie which JDKs, what part of build process) Normally anything com.sun.* should be hidden from the users, and I have not seen the same issue so I am reluctant to add this to the repo for all users... |
I am using openjdk@21 installed using brew. Here is the complete output on Mac laptop:
|
Ok, so its ErrorProne causing the issue. Can you remove or comment out lines 121 and 129-130 from pom.xml and see if it helps? <!-- <arg>-Xplugin:ErrorProne -XepExcludedPaths:${project.build.directory}/generated-sources/.* -XepDisableWarningsInGeneratedCode</arg> -->
...
<!-- <path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>${error-prone.version}</version>
</path> --> |
And indeed, Errorprone docs mention the issue in Maven and JDK 16+ |
Can you check to see if the change in #100 fixes it for you. (and yes I can now repro locally - while I had JDK 17 installed, JDK 11 was the version being used by default due to PATH shenanigans!) |
(PS thanks for raising these issues!) |
Pulled the latest code from main branch:
|
The main branch did not have the fix in at the time - it was in my PR - because at the time I posted, I could not test the fix - but since then I was able to repro and verify that #100 fixes the issue. now that #100 is merged, main should include the fix (by updating pom.xml with the javac args) |
Verified that it is working |
On Mac with various JDKs I could not do
mvn compile
. Ultimately found solution to have.mvn/jvm.config
with following contents:Please include this in the repository
The text was updated successfully, but these errors were encountered: