Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invert Selection" depends on setSelectionMode (not set) #145

Open
m-7761 opened this issue Sep 7, 2020 · 1 comment
Open

"Invert Selection" depends on setSelectionMode (not set) #145

m-7761 opened this issue Sep 7, 2020 · 1 comment

Comments

@m-7761
Copy link

m-7761 commented Sep 7, 2020

I don't know, maybe it should be used in combination with the selection tools? Anyway, the selection tools don't call setSelectionMode automatically. I'm going to have them do so in the activate method and see if it sticks?

It looks safe except for selectFreeVertices that "Select Free Vertices" uses. I was just going to work on that anyway! Like today. I'm looking at this stuff as I compose this Issue. Sorry.

As an aside selectFreeVertices doesn't really work properly. I had a model today with free vertices that it couldn't select. I'm going to remove "m_free" (I think) since I have a member that is a list of faces belonging to each vertex, that can just be checked to see if it's empty or not. And remove setSelectionMode at the same time.

@m-7761 m-7761 changed the title Invert Selection" depends on setSelectionMode (not set) "Invert Selection" depends on setSelectionMode (not set) Sep 7, 2020
@m-7761
Copy link
Author

m-7761 commented Sep 7, 2020

For the record, selectFreeVertices doesn't have a reason for calling setSelectionMode as it stands. I think it should not be exposed as a public API and should default to face mode. It should only be available to the Tool system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant